Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(android-connectivity): Add ethernet connection type #5670

Merged
merged 4 commits into from
Apr 19, 2018

Conversation

crowebird
Copy link
Contributor

When calling getConnectionType on an emulator, the connection type can be returned as "ethernet", which causes getConnectionType to return none when there is a connection.

PR Checklist

What is the current behavior?

If the connection type is "ethernet" getConnectionType will return none.

What is the new behavior?

If the connection type is "ethernet" getConnectionType will properly return the "ethernet" connection type

Fixes/Implements/Closes #5669.

Add "ethernet" connection type to getConnectionType to correctly return a connection type when the type is "ethernet"
@ns-bot
Copy link

ns-bot commented Apr 12, 2018

Can one of the admins verify this patch?

1 similar comment
@ns-bot
Copy link

ns-bot commented Apr 12, 2018

Can one of the admins verify this patch?

@ghost ghost added the ♥ community PR label Apr 12, 2018
@ns-bot
Copy link

ns-bot commented Apr 12, 2018

Can one of the admins verify this patch?

@manoldonev manoldonev added this to the 4.1 milestone Apr 13, 2018
@ghost ghost assigned SvetoslavTsenov Apr 16, 2018
@ghost ghost added in progress and removed ♥ community PR labels Apr 16, 2018
@ghost ghost assigned manoldonev Apr 18, 2018
@manoldonev
Copy link
Contributor

test

@manoldonev manoldonev merged commit 1536d15 into NativeScript:master Apr 19, 2018
@ghost ghost removed the in progress label Apr 19, 2018
@lock
Copy link

lock bot commented Aug 26, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Aug 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] getConnectionType returns none when the connectionType is "ethernet"
4 participants