Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Image): catch Response content may not be converted to an Image #5856

Merged
merged 4 commits into from
Jun 13, 2018

Conversation

NathanWalker
Copy link
Contributor

@NathanWalker NathanWalker commented May 24, 2018

closes NativeScript/nativescript-angular#851
addresses part of #3381

PR Checklist

What is the current behavior?

Apps fail when this error occurs.

What is the new behavior?

Developers can now have a meaningful and productive debugging session to make great apps. Error is now properly caught and with tracing enabled with Debug category developers may now easily pick up these types of issues.

closes NativeScript/nativescript-angular#851
addresses part of #3381

@ghost ghost assigned vakrilov Jun 6, 2018
@ghost ghost added in progress and removed ♥ community PR labels Jun 6, 2018
@vakrilov
Copy link
Contributor

vakrilov commented Jun 6, 2018

test

@vakrilov
Copy link
Contributor

test

@ghost ghost assigned SvetoslavTsenov Jun 13, 2018
@vakrilov vakrilov merged commit 5cd8a1f into NativeScript:master Jun 13, 2018
@ghost ghost removed the in progress label Jun 13, 2018
@lock
Copy link

lock bot commented Aug 26, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Aug 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Image src returning invalid image causes application failures
4 participants