fix(ios-dialogs): unable to show dialog from modal view without a page #5881
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #5879
The original problem occurred in an Angular app (Plugins team teamplate), that displays some dialogs inside modal view, bacause we are no longer wrapping modal view inside a Page in nativescript-angular@next.
This could also happen in a non Angular application (modal view without
<Page>
)The solution is to search up in the hierarchy for a parent with UIViewController on which we should present the dialog.
Added test in modal-navigation app that opens dialog from modal view (with and without wrapping modal view content in Page)