-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(modal): parent page invalid hierarchy handling [extended] #5966
Conversation
@@ -356,6 +364,11 @@ export class View extends ViewCommon { | |||
} | |||
|
|||
protected _hideNativeModalView(parent: View) { | |||
if (!parent || !parent.viewController) { | |||
traceError("Trying to hide modal view but no parent with viewController specified.") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's highly unlikely that the parent is undefined here as it's only called _closeModalCallback where it is scoped. Guard it and viewController
prop access anyway.
test |
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Extension of #5841:
_showNativeModalView
in_hideNativeModalView
getParentWithViewController
refactor to be more conciseshowUIAlertController
methodCC @NathanWalker