Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dialogs-ios): dialogs not showing in non Frame based apps #6000

Merged
merged 3 commits into from
Jul 3, 2018

Conversation

ADjenkov
Copy link
Contributor

Solution: Search for the root view's viewController when no current page available (no topmost frame)

Tests: e2e tests already available for these scenarios

Fix #5931

@ADjenkov ADjenkov added the bug label Jun 27, 2018
@ADjenkov ADjenkov self-assigned this Jun 27, 2018
@ghost ghost added the in progress label Jun 27, 2018
@MartoYankov MartoYankov merged commit 0082dfb into master Jul 3, 2018
@ghost ghost removed bug in progress labels Jul 3, 2018
@MartoYankov MartoYankov deleted the djenkov/dialogs branch July 3, 2018 07:23
@lock
Copy link

lock bot commented Aug 26, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Aug 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[iOS] Dialogs don't work on iOS
2 participants