feat(HMR): apply changes in page styles at runtime #6857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
vchimev
requested review from
vakrilov,
manoldonev,
MartoYankov and
ADjenkov
and removed request for
vakrilov and
manoldonev
vchimev
changed the title
vchimev
force-pushed
the
vchimev/hmr-page-styles
branch
from
ae5ca26
to
31a795e
Compare
vchimev
changed the title
vchimev
force-pushed
the
vchimev/hmr-page-styles
branch
from
31a795e
to
be4b7f7
Compare
vchimev
force-pushed
the
vchimev/hmr-page-styles
branch
from
a6b0d17
to
d6da422
Compare
MartoYankov
reviewed
Feb 13, 2019
MartoYankov
reviewed
Feb 13, 2019
Add a comment. Update `let` to `const`. Update `changesCssFile` test.
MartoYankov
approved these changes
Feb 14, 2019
5 tasks
3 tasks
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
What is the current behavior?
Currently, a style change in page
.cssor.scssnavigates to the same page where the change is applied.What is the new behavior?
The new behavior uses the context passed by
nativescript-dev-webpackto determinate whether changes have been made to page.cssor.scssfile. If so, apply them at runtime and avoid executing navigation to the same page.This is an implementation for the scenarios where the root of the app is a
Frame.