fix: WrappedValue.unwrap empty string behavior

[speigg]

Currently:

var value = new WrappedValue('') // passing empty string
console.log(WrappedValue.unwrap(value) === '' ) // prints "false"

Now:

var value = new WrappedValue('') // passing empty string
console.log(WrappedValue.unwrap(value) === '' ) // prints "true"

PR Checklist

• The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/CONTRIBUTING.md#commit-messages.
• There is an issue for the bug/feature this PR is for. To avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it.
• You have signed the CLA.
• All existing tests are passing: https://github.com/NativeScript/NativeScript/blob/master/DevelopmentWorkflow.md#running-unit-tests.
• Tests for the changes are included - https://github.com/NativeScript/NativeScript/blob/master/WritingUnitTests.md.

What is the current behavior?

What is the new behavior?

Fixes/Implements/Closes #[Issue Number].

[manoldonev]

@speigg there are failing unit tests with this change:

JS: Test: --- [XML-DECLARATION.test_TabViewHasCorrectParentChain] FAILED: Cannot use 'in' operator to search for 'wrapped' in true, Stack: TypeError: Cannot use 'in' operator to search for 'wrapped' in true

You can run the unit tests locally like this:

cd tests
tns run android

[vakrilov]

As @manoldonev pointed out - the proposed solution fails when unwrap is given a boolean value.
Lets just make an instanceof check:

return (value instanceof WrappedValue) ? value.wrapped : value;

Also, can you add some unit-tests about this case. You can check this guide on how to do that.

[vakrilov]

@cla-bot check

[cla-bot]

The cla-bot has been summoned, and re-checked this pull request!

[speigg]

@manoldonev thanks for taking care of this, I haven't had time to work on this myself

[manoldonev]

test

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.