Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ios): opaque bars break ui layout #6929

Merged
merged 3 commits into from
Feb 20, 2019
Merged

Conversation

MartoYankov
Copy link
Contributor

@MartoYankov MartoYankov commented Feb 19, 2019

The extendedLayoutIncludesOpaqueBars property set to true unifies layout behavior between translucent and opaque bars in iOS. Remove additional special handling for flat action bars.

fixes #6891
fixes #6684

Has 2 new ui tests - /action-bar/flat-layout and /action-bar/flat-tab-opaque-bar.

@MartoYankov MartoYankov self-assigned this Feb 19, 2019
@ghost ghost added the in progress label Feb 19, 2019
@MartoYankov MartoYankov changed the base branch from master to release February 19, 2019 14:07
@MartoYankov
Copy link
Contributor Author

test package_version#latest

@MartoYankov
Copy link
Contributor Author

test package_version#latest

@MartoYankov MartoYankov merged commit 09fa085 into release Feb 20, 2019
@ghost ghost removed the in progress label Feb 20, 2019
@MartoYankov MartoYankov deleted the myankov/opaque-bars-2 branch February 20, 2019 16:46
SvetoslavTsenov added a commit that referenced this pull request Feb 21, 2019
@lock
Copy link

lock bot commented Mar 10, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Mar 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants