fix(ios-webview): report hostname lookup errors in loadFinished event #6988
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Certain types of WKWebView errors (including hostname resolution failures) are reported to webViewDidFailProvisionalNavigationWithError. The delegate needs to implement this function for applications to detect and react to these types of errors.
PR Checklist
What is the current behavior?
On iOS, the
loadFinished
event is never emitted if the hostname in the URL can't be found.What is the new behavior?
loadFinished
is emitted with theerror
property set on the event object when a hostname lookup error occurs. This is in line with what the documentation suggests should occur, and the behavior on Android.Fixes #6987.