Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: introduce fixed font icons to tab navigation #7691

Merged
merged 10 commits into from Aug 22, 2019

Conversation

MartoYankov
Copy link
Contributor

Add new property fixedIcons that defaults to true that fixes icon sizes to the spec size - 24x24 with max width 31 and max height 28 allowed. Set to false to use the actual size of the images.

@manoldonev manoldonev added the docs needed Additional documentation on this issue/PR is needed label Aug 19, 2019
@manoldonev
Copy link
Contributor

manoldonev commented Aug 20, 2019

@MartoYankov Android Bottom Navigation icon change scenario still does not look OK out-of-the-box but we'll investigate it after feature freeze (will log it).

Screenshot_1566317899

@manoldonev
Copy link
Contributor

manoldonev commented Aug 20, 2019

@MartoYankov iOS Bottom Navigation font icons scenario -- third font icon gets clipped upon activation (will log it):

Simulator Screen Shot - iPhone Xʀ - 2019-08-20 at 19 43 56
Simulator Screen Shot - iPhone Xʀ - 2019-08-20 at 19 44 03

@manoldonev
Copy link
Contributor

@MartoYankov iOS Tabs font icons scenario looks broken -- font icon color is wrong (will log it):

Simulator Screen Shot - iPhone Xʀ - 2019-08-20 at 19 47 42

@manoldonev
Copy link
Contributor

@MartoYankov iOS tabs icon change scenario still does not change the icon (will log it):

Simulator Screen Shot - iPhone Xʀ - 2019-08-20 at 19 48 30

@MartoYankov
Copy link
Contributor Author

@manoldonev

  1. First one should be investigated.

  2. Regarding the clipped icon - I believe this is expected. If you look closely the icon is clipped before the tab item is activated too. This is the case when the font is wrong and doesn't support icons. It's not an issue with the scaling, but with the font itself. If you do this in a Label the result will be the same.

  3. Regarding the iOS Tabs icon colors, this is a decision/limitation I imposed. Since the color property can't apply on the titles (because of MDCTabBar limitation) I disabled it on the icons as well. Now for both the color property value of the TabStrip is the valid one. It's possible to do it for the icons since they are simply images, but looks weird.

@manoldonev
Copy link
Contributor

test api19

@manoldonev manoldonev merged commit 8039c2c into master Aug 22, 2019
@manoldonev manoldonev deleted the myankov/tab-icon-size branch August 22, 2019 07:26
@manoldonev
Copy link
Contributor

@MartoYankov is the last (fourth) issue also a limitation of the MDCTabBar usage (about iOS tabs icon change example not working) or should I log it?

@rigor789 rigor789 removed the docs needed Additional documentation on this issue/PR is needed label Oct 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants