New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: introduce fixed font icons to tab navigation #7691
Conversation
tns-core-modules/ui/bottom-navigation/bottom-navigation.android.ts
Outdated
Show resolved
Hide resolved
tns-core-modules/ui/bottom-navigation/bottom-navigation.android.ts
Outdated
Show resolved
Hide resolved
tns-core-modules/ui/tab-navigation-base/tab-navigation-base/tab-navigation-base.d.ts
Outdated
Show resolved
Hide resolved
tns-core-modules/ui/tab-navigation-base/tab-navigation-base/tab-navigation-base.d.ts
Outdated
Show resolved
Hide resolved
@MartoYankov Android Bottom Navigation icon change scenario still does not look OK out-of-the-box but we'll investigate it after feature freeze (will log it). |
@MartoYankov iOS Bottom Navigation font icons scenario -- third font icon gets clipped upon activation (will log it): |
@MartoYankov iOS Tabs font icons scenario looks broken -- font icon color is wrong (will log it): |
@MartoYankov iOS tabs icon change scenario still does not change the icon (will log it): |
|
test api19 |
@MartoYankov is the last (fourth) issue also a limitation of the MDCTabBar usage (about iOS tabs icon change example not working) or should I log it? |
Add new property
fixedIcons
that defaults totrue
that fixes icon sizes to the spec size - 24x24 with max width 31 and max height 28 allowed. Set tofalse
to use the actual size of the images.