feat(css): add attribute scoped css without global refresh (#7907) #7947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manoldonev
approved these changes
Oct 11, 2019
vakrilov
approved these changes
Oct 11, 2019
|
This PR is basically adding a new feature. I'm not sure this is good for a patch. Also, I've communicated with the guy who initially reported the issue and helped me isolate it that it will come out with {N} 6.2 at the end of the month. |
|
@MartoYankov Generally I agree with you but as this change is triggered by a nativescript-angular fix, we need to release it with a patch in tns-core-modules as with 6.2.0 we'll be releasing a patch version of nativescript-angular (nativescript-angular versioning is tied to angular major and minor releases) that will rely on this fix and otherwise it will break all users (e.g. if you have a dependency like |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a patch PR for #7907