Fix: Angular no longer has issues with plugins that aren't named "nativescript" #9172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
What is the current behavior?
When webpacking in Angular; it requires the plugins to have the name "nativescript", "@NativeScript", "tns" somewhere in it. If it doesn't have it -- it will not consider it a plugin to do any .ios. / .android. file renaming causing the build to fail.
What is the new behavior?
Makes angular be consistent with all the other flavors, and now does NOT care about the package name in its check to see if it is a file it needs to rename.
It does add about between a -10% to a +5% slowdown to just the WebPack portion of the build depending on the size of the application. (No other speed or size impacts) In smaller apps; the webpacking is now faster. In apps that take about 30 seconds for just the webpacking, it adds an additional second.