New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(bottom-navigation): fragment handling #9244

Merged

NathanWalker merged 1 commit into master from fix/fragment-handling

Feb 25, 2021

Member

rigor789 commented Feb 24, 2021 •

edited

PR Checklist

The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/tools/notes/CONTRIBUTING.md#commit-messages.
There is an issue for the bug/feature this PR is for. To avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it.
You have signed the CLA.
All existing tests are passing: https://github.com/NativeScript/NativeScript/blob/master/tools/notes/DevelopmentWorkflow.md#running-unit-tests-application.
Tests for the changes are included - https://github.com/NativeScript/NativeScript/blob/master/tools/notes/WritingUnitTests.md.

What is the current behavior?

What is the new behavior?

Fixes/Implements/Closes #[Issue Number].


          fix(bottom-navigation): fragment handling

7c9f833

cla-bot bot added the cla: yes label

NathanWalker marked this pull request as ready for review

February 25, 2021 01:34

NathanWalker approved these changes

View reviewed changes

NathanWalker merged commit c8ef6f2 into master

NathanWalker deleted the fix/fragment-handling branch

February 25, 2021 01:35

NathanWalker pushed a commit that referenced this pull request


          fix(bottom-navigation): fragment handling (#9244)

932ad41

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment