Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Set package version before preReleaseBuild #1716

Merged
merged 1 commit into from
Jul 14, 2022
Merged

fix: Set package version before preReleaseBuild #1716

merged 1 commit into from
Jul 14, 2022

Conversation

sebj54
Copy link
Contributor

@sebj54 sebj54 commented Jul 5, 2022

Fixes #1715

⚠️ This PR might have unintended side effects.

It's working and has been tested on a demo project, but as I am not really familiar with Gradle files, it may have some side effects.

I invite you to test it with my demo project: https://github.com/sebj54/ns-debug-runtime-version

git clone https://github.com/sebj54/android-runtime.git
git clone https://github.com/sebj54/ns-debug-runtime-version.git
cd android-runtime
./gradlew
cd ../ns-debug-runtime-version
npm install ../android-runtime/dist
git checkout package.json
ns run android --release

If you run ./gradlew multiple times, be sure to discard changes in Version.h before build:

git checkout test-app/runtime/src/main/cpp/Version.h
./gradlew

I think it is also mandatory to clean platforms/android directory before building the app.

@cla-bot cla-bot bot added the cla: yes label Jul 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

__runtimeVersion equals 0.0.0.0 in release builds since @nativescript/android 8.2.3
2 participants