-
-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GVRKit plugin metadata generation issue #877
Comments
Hi, I have the same issues with StarIO-framework.
This is not the only place I have discovered it. It is the same with Is there a plan to fix this? |
The issue is in
The problem is when there are two similar methods. I see three ways to solve this:
An example for alt. 3 above:
The ObjC signatures are
They only differ by a colon (since the first argument is not included in the signature name) This could generate "overloaded" typescript definitions like
and the implementation something like
I have not checked how the actual implementation of js->objc functions work but I believe something like this could be doable and not very intrusive/breaking. A similar example with appendMultiple: ObjectiveC methods:
The ObjC signatures are
typescript overloads
and the implementation something like
|
Hi @ulvesked. Thank you for the ideas presented. I like approach number 3 the most, but it has a small drawback - there could still be cases where the number of arguments will be the same. Consider the following hypothetical example:
Both methods would end up with the same name ( We will try to fix the issue for the upcoming 5.0 release of {N}. |
I have a GVRKit plugin that I have been developing for a project, and the runtime metadata is incorrect, and I need to find a solution to get around this in NativeScript.
In some ways slightly related to #826 (Like him I've got one that is working).
Partially related to this issue #710...
Error is:
Error: Actual arguments count: "0". Expected: "1".
Do you see that the metadata JS name is the SAME, but the core name is different. One has a prototype of:
bool handleTrigger()
and the other is
bool handleTrigger(GVRHeadPose *headpose)
I really want to call the first option. I can't seem to because NativeScript has decided the only valid one is the second one. ;-(
Solutions?
The text was updated successfully, but these errors were encountered: