fix(bridge): Synchronize access to Strong handles in collection adapters #1144
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
TNSArrayAdapter
,TNSDataAdapter
andTNSDictionaryAdapter
holdStrong
references to their underlying JS objects. When the Objective-C instances of these
classes were
dealloc
-ed, these references' destructors were being called outsideof the JSC VM's lock which lead to nasty and rarely occurring crashes when such
adapters are being used in threads different than the main thread of the JSC engine.
ExecState
s as calls to an adapter can be made long after the JSstate has changed. Use global object's
globalExec
instead.Strong
handles inside the locked section. This way the C++ destructorof a nullptr handle will not have to modify anything in the VM's heap.
Dump the native and JavaScript callstacks when any
of SIGABRT SIGILL, SIGSEGV, SIGFPE or SIGBUS is received.