Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(project-template): Correctly get architecture in nsld with Xcode 11 #1179

Merged
merged 1 commit into from
Aug 1, 2019
Merged

fix(project-template): Correctly get architecture in nsld with Xcode 11 #1179

merged 1 commit into from
Aug 1, 2019

Conversation

mbektchiev
Copy link
Contributor

Xcode 11 doesn't specify an -arch argument but uses -target instead

PR Checklist

@mbektchiev
fix(project-template): Correctly get architecture in nsld with Xcod…
ce6b343 
…e 11

Xcode 11 doesn't specify an `-arch` argument but uses `-target` instead
@mbektchiev mbektchiev added the bug label Jul 31, 2019
@mbektchiev mbektchiev added this to the 6.1.0 milestone Jul 31, 2019
@mbektchiev mbektchiev self-assigned this Jul 31, 2019
@cla-bot cla-bot bot added the cla: yes label Jul 31, 2019
@mbektchiev mbektchiev merged commit ca62e22 into master Aug 1, 2019
@mbektchiev mbektchiev deleted the bektchiev/fix-swift-support-xcode-11 branch August 1, 2019 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vmutafov vmutafov vmutafov approved these changes

@vtrifonov vtrifonov Awaiting requested review from vtrifonov

Assignees

@mbektchiev mbektchiev

Labels
bug cla: yes
Projects
None yet
Milestone
6.1.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mbektchiev @vmutafov