Performance improvements for method calls #438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
class_conformsToProtocol is too heavy to invoke on every method call so replace it with something lighter.
Get rid of WTF::ThreadSpecific
|
Test PASSed. |
| @@ -21,6 +21,10 @@ | |||
| #include "Interop.h" | |||
| #include "TNSFastEnumerationAdapter.h" | |||
|
|
|||
| @protocol TNSDerivedClass | |||
There was a problem hiding this comment.
Is it possible to completely remove this protocol now?
There was a problem hiding this comment.
It's still used within the class builder and I can't figure out a substitution. It's not on a hot path there so I guess it's fine.
ivanbuhov
added a commit
that referenced
this pull request
Dec 11, 2015
…formance-performance Performance improvements for method calls
ivanbuhov
deleted the
fealebenpae/performance-performance-performance
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This yields a ~100% performance improvement in synthetic benchmarks.