feat: URL & URLSearchParams #234
Conversation
|
maybe this (and the android counterpart) can be written using the new node way of binding modules (so no changes needed in the Runtime.h/mm): https://github.com/NativeScript/ios/pull/221/files Also, I think we should just use "URL" instead of URLImpl for the property |
|
This seems way nicer |
|
See my pre-review comments on the equivalent Android PR – I've got the same questions about this repo as well. And thanks again! |
NathanWalker
force-pushed
the
feat/ada-url-y-search-params
branch
4 times, most recently
from
33515bd
to
c604b9f
Compare
NativeScript/runtime/Runtime.mm
Outdated
| URL.createObjectURL = function (object, options = null) { | ||
| try { | ||
| if (object instanceof Blob || object instanceof File) { | ||
| const id = NSUUID.UUID().UUIDString; |
There was a problem hiding this comment.
@triniwiz you need to convert the UUID to lowercase. iOS generates UUID in uppercase but the standard is to use lower case:
Are UUIDs Case-sensitive?
No, UUIDs are written in base 16 which uses numbers 0-9 and characters a-f. There is no distinction between upper and lowercase letters. However, RCF 4122 section 3 requires that UUID generators output in lowercase and systems accept UUIDs in upper and lowercase.
…se lite url version
NathanWalker
force-pushed
the
feat/ada-url-y-search-params
branch
from
1f0a6b5
to
4c11dab
Compare
This reverts commit dc3c76f.
No description provided.