Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Xcode11] Launch images are deprecated in iOS 13.0 #4938

Closed
1 task
DimitarTachev opened this issue Aug 9, 2019 · 1 comment
Closed
1 task

[Xcode11] Launch images are deprecated in iOS 13.0 #4938

DimitarTachev opened this issue Aug 9, 2019 · 1 comment
Assignees
@KristianDD
Labels
bug build Describes issues related to build operations os: ios
Projects
CLI Team
Milestone
6.1.1

Comments

@DimitarTachev
Copy link
Contributor

DimitarTachev commented Aug 9, 2019 •
edited by KristianDD

Environment

  • CLI: 6.0.3
  • Cross-platform modules: 6.0.1
  • iOS Runtime: 6.0.1

Describe the bug
Building a HelloWorld JS app using Xcode 11 beta 5 is showing the following warning:
jsHelloWorld/platforms/ios/jsHelloWorld/Resources/Assets.xcassets:./LaunchImage.launchimage: warning: Launch images are deprecated in iOS 13.0. Use a launch storyboard or XIB instead.

To Reproduce

  1. npm i nativescript@latest
  2. sudo xcode-select -s <path-to-your-xcode11-beta5>
  3. tns create jsHelloWorld --js && cd jsHelloWorld
  4. tns build ios --emulator

Expected behavior
The app should be built without any warnings.

Acceptance criteria

  • The warning should be present with live templates and missing with rc templates

Related to: #4909
@project-bot project-bot bot added this to Inbox in CLI Team Aug 9, 2019
@DimitarTachev DimitarTachev changed the title [xCode11] Launch images are deprecated in iOS 13.0. [Xcode11] Launch images are deprecated in iOS 13.0. Aug 9, 2019
@DimitarTachev DimitarTachev added this to the 6.1.0 milestone Aug 9, 2019
@DimitarTachev DimitarTachev moved this from Inbox to Planned (post 6.0.0) in CLI Team Aug 9, 2019
@Fatme Fatme mentioned this issue Aug 9, 2019
Closed
10 tasks
@DimitarTachev DimitarTachev added the build Describes issues related to build operations label Aug 9, 2019
@DimitarTachev DimitarTachev changed the title [Xcode11] Launch images are deprecated in iOS 13.0. [Xcode11] Launch images are deprecated in iOS 13.0 Aug 9, 2019
@rosen-vladimirov rosen-vladimirov moved this from Planned (post 6.0.0) to Planned in CLI Team Aug 16, 2019
@rosen-vladimirov rosen-vladimirov modified the milestones: 6.1.0, 6.1.1 Sep 5, 2019
@rosen-vladimirov rosen-vladimirov moved this from Planned to In Progress in CLI Team Sep 5, 2019
@KristianDD KristianDD mentioned this issue Sep 10, 2019
Merged
4 tasks
@KristianDD KristianDD moved this from In Progress to Ready for Test in CLI Team Sep 11, 2019
@KristianDD KristianDD moved this from Ready for Test to In Progress in CLI Team Sep 11, 2019
@KristianDD KristianDD moved this from In Progress to Ready for Test in CLI Team Sep 11, 2019
@KristianDD
Copy link
Contributor

The solution to remove the warnings is:

  1. In ../App_Resources/iOS/build.xcconfig the configuration ASSETCATALOG_COMPILER_LAUNCHIMAGE_NAME = LaunchImage; should be removed.
  2. ../App_Resources/iOS/Assets.xcassets/LaunchImage.launchimage should be deleted

CLI Team automation moved this from Ready for Test to Done Sep 12, 2019
@JeanLenormand JeanLenormand mentioned this issue Nov 21, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@KristianDD KristianDD

Labels
bug build Describes issues related to build operations os: ios
Projects
CLI Team
  
Done
Milestone
6.1.1
Development

No branches or pull requests
4 participants
@DimitarTachev @KristianDD @endarova @rosen-vladimirov