fix(clean) report failures to remove item

[jcassidyav]

PR Checklist

• The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/CONTRIBUTING.md#commit-messages.
• There is an issue for the bug/feature this PR is for. To avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it.
• You have signed the CLA.
• All existing tests are passing: https://github.com/NativeScript/nativescript-cli/blob/master/CONTRIBUTING.md#contribute-to-the-code-base
• Tests for the changes are included.

What is the current behavior?

If ns clean failed to remove an item ( which is common on windows where the platforms directory is not removed properly), there was no indication to the user.

What is the new behavior?

Now the output of ns clean will indicate which item was not removed.
e.g.

_ Cleaning project...√ Cleaned directory hooks
× Failed to Clean directory platforms
√ Cleaned directory node_modules
√ Cleaned file package-lock.json
× Project unsuccessfully cleaned.

Fixes/Implements/Closes #5588.

[rigor789]

Very nice improvement, I've definitely ran into the windows filesystem issues...

I've left a few minor suggestions for variable names, but overall LGTM! 👍

[jcassidyav]

@rigor789 thanks, I didn't realize my workspace wasn't linting, and I agree it is more readable for the variable names to be success.

[vallemar]

I applaud this PR, I would like to force the deletion of the platform folder. Some time ago someone commented in discord this script to eliminate the process that has it busy. Couldn't this be added before deleting this folder to ensure its deletion?

$process=(Get-WmiObject Win32_Process -Filter "name = 'java.exe' AND CommandLine like '%gradle%'")
if(-NOT ( $process  -EQ $Null)){
    echo Terminating $process.CommandLine
    $process.Terminate() | Out-Null
}

I say this because this behavior is a warming up of the head ...

[jcassidyav]

@vallemar I posted that script to discord, but I think that would be a step too far to add to the cli, as who knows what people have running on their machines either now or in the future which would match that query.

A little later in discord I posted that from what I can see, this particular case is caused by The Gradle Daemon, the details on this process are documented here https://docs.gradle.org/current/userguide/gradle_daemon.html.

There are multiple options to turn it off, e.g. setting then environment variable documented here https://docs.gradle.org/current/userguide/gradle_daemon.html#daemon_faq
which prevents this happening for me.

[vallemar]

@jcassidyav amazing. So if this can be disabled, do you think it would be okay to put something in the ns clean documentation? I'm also wondering if it would be okay to put a --force flag or something like that so that it launches the above query and closes the gradle process. What do you think? I do not know if they work with Windows in NS but it is a real nuisance