Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: --gradlePath argument support #5628

Merged
merged 5 commits into from
Feb 15, 2022
Merged

feat: --gradlePath argument support #5628

merged 5 commits into from
Feb 15, 2022

Conversation

farfromrefug
Copy link
Contributor

@farfromrefug farfromrefug commented Feb 15, 2022 •
edited

This simple PR add --gradle option to specify a custom gradle binary path
Solves #5550

EDIT: renamed the option to gradlePath. makes more sense as i am about to add gradle option for args

@project-bot project-bot bot added this to Pull Request in CLI Team Feb 15, 2022
@cla-bot cla-bot bot added the cla: yes label Feb 15, 2022
@farfromrefug farfromrefug mentioned this pull request Feb 15, 2022
Closed
@rigor789 rigor789 changed the title Gradle option feat: --gradlePath argument support Feb 15, 2022
rigor789
rigor789 approved these changes Feb 15, 2022
View reviewed changes
Copy link
Member

@rigor789 rigor789 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rigor789 rigor789 merged commit 387c7c0 into NativeScript:master Feb 15, 2022
CLI Team automation moved this from Pull Request to Done Feb 15, 2022
@farfromrefug farfromrefug deleted the gradle_option branch February 15, 2022 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rigor789 rigor789 rigor789 approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
CLI Team
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@farfromrefug @rigor789