Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(doctor): improve target and sdk compatibility detection on <8.2 #5648

Merged
merged 4 commits into from
Mar 11, 2022

Conversation

edusperoni
Copy link
Collaborator

@edusperoni edusperoni commented Mar 11, 2022

PR Checklist

What is the current behavior?

Building with build-tools 31 or 32 on @nativescript/android < 8.2 fails.

What is the new behavior?

Building on < 8.2 now tries to use a supported targetSdk, compileSdk and buildToolsVersion, or otherwise fails with a message indicating the issue (missing build-tools in the correct range).

@project-bot project-bot bot added this to Pull Request in CLI Team Mar 11, 2022
@cla-bot cla-bot bot added the cla: yes label Mar 11, 2022
@edusperoni edusperoni changed the title fix: limit android targets on cli <8.2 fix: limit android targets on runtime <8.2 Mar 11, 2022
@rigor789 rigor789 changed the title fix: limit android targets on runtime <8.2 fix(doctor): improve target and sdk compatibility detection on <8.2 Mar 11, 2022
@rigor789 rigor789 merged commit fa257dd into NativeScript:master Mar 11, 2022
CLI Team automation moved this from Pull Request to Done Mar 11, 2022
@edusperoni edusperoni deleted the fix/android-targets-82 branch March 15, 2022 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
CLI Team
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants