Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: cleaner log output #5680

Merged
merged 5 commits into from
Jul 25, 2022
Merged

feat: cleaner log output #5680

merged 5 commits into from
Jul 25, 2022

Conversation

rigor789
Copy link
Member

@rigor789 rigor789 commented Jul 22, 2022

PR Checklist

What is the current behavior?

Screenshot 2022-07-22 at 10 44 26 PM

What is the new behavior?

Screenshot 2022-07-22 at 10 45 34 PM

Additional devices will get assigned a different color to easily see which device the logs are coming from.

@rigor789 rigor789 marked this pull request as ready for review July 25, 2022 18:23
@rigor789 rigor789 merged commit 5330207 into master Jul 25, 2022
CLI Team automation moved this from Pull Request to Done Jul 25, 2022
@rigor789 rigor789 deleted the feat/cleaner-logs branch July 25, 2022 18:23
@ett-hyoshida
Copy link

@rigor789 Excellent!

In the case of multiline (e.g. object) the indentation is lost.
So I would like it to not trim() or change to trimEnd() in device-log-provider.ts#logDataCore

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
CLI Team
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants