Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: hmr doesn't work properly in paths with the character '.' #5703

Merged
merged 1 commit into from
Nov 25, 2022

Conversation

dgmachado
Copy link
Contributor

@dgmachado dgmachado commented Nov 25, 2022

PR Checklist

What is the current behavior?

The hmr doesn't work properly in paths with the character '.'. Steps to reproduce:

  1. Create folder named a.b-t14.32
  2. Enter on the a.b-t14.32 folder
  3. Create a ns project using angular template inside
  4. Run "ns run ios"
  5. Change the app.ts file and save the changes.

Actual result:

The app doesn't restart

Expected result:

The app restart.

What is the new behavior?

After change the app.ts file and save the changes the app restarts properly.

Issue

The issue was happening on the wepack compiler service. The hash value wasn't being computed properly.

Before fix:
before-fix

After fix:
after-fix

@cla-bot cla-bot bot added the cla: yes label Nov 25, 2022
@rigor789 rigor789 merged commit 7a312a2 into NativeScript:main Nov 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants