Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Any plans to update Android to version 5 #201

Closed
FranciZ opened this issue Jul 2, 2019 · 4 comments
Closed

Any plans to update Android to version 5 #201

FranciZ opened this issue Jul 2, 2019 · 4 comments
Labels
feature
Projects
Plugins Team

Comments

@FranciZ
Copy link

FranciZ commented Jul 2, 2019

App install ads require apps to implement version 5 of the plugin. Are there any plans to upgrade the android side of the plugin to 5?

As far as I see iOS is already on version5.

Thanks!
@project-bot project-bot bot added this to Inbox in Plugins Team Jul 2, 2019
@DimitarTodorov
Copy link
Contributor

Hi @FranciZ ,
We've migrated to latest version of iOS android.facebook.sdk since there was an issue, which was fixed in the latest sdk. There was no need at the time being to udpate the android.sdk of the plugin to latest. We will review the changelog of the sdk and will update it at some point.
Meanwhile we love contributors and we are open for PRs. You are welcome to update it and propose a PR with the change, we can review and release an update of the plugin after.
Regards,
NativeScript Team

@narusevic
Copy link
Contributor

After updating to newest tns, angular versions, this error appeared: https://stackoverflow.com/questions/57543127/android-gradle-fail-aapt-error-resource-color-com-facebook-button-background

@narusevic narusevic mentioned this issue Aug 22, 2019
Closed
@narusevic
Copy link
Contributor

Created PR #208

@elena-p elena-p moved this from Inbox to In Progress in Plugins Team Aug 30, 2019
@elena-p elena-p moved this from In Progress to Review / QA in Plugins Team Aug 30, 2019
@zbranzov zbranzov moved this from Review / QA to Ready for Release in Plugins Team Sep 10, 2019
@zbranzov
Copy link
Contributor

Published in nativescript-facebook@4.2.0

Plugins Team automation moved this from Ready for Release to Done Sep 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature
Projects
Plugins Team
  
Done
Milestone
No milestone
Development

No branches or pull requests
4 participants
@FranciZ @zbranzov @DimitarTodorov @narusevic