Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RadListView] Swipe actions not working as expected #1340

Closed
quinnban opened this issue Jan 24, 2020 · 2 comments
Closed

[RadListView] Swipe actions not working as expected #1340

quinnban opened this issue Jan 24, 2020 · 2 comments
Labels

Comments

@quinnban
Copy link

Please take a minute to read our NativeScript Code of Conduct before proceeding with posting issues or discussing. The purpose of this guide is to make communication and cooperation within our forums a pleasure for you and the other members.

Please, provide the details below:

Tell us about the problem

When following the instructions on the website the swipe events do not work was expected.

  1. On Android the "itemSwipeProgressEnded" event will always return 0 for the 'data.x'
  2. On IOS the swipe does not map '1-1' with the users finger.
  3. On IOS the swipe limits seem to not matter, the user can swipe either was regardless of if the swipe limit was set to 0.

Which platform(s) does your issue occur on?

Both

Please provide the following version numbers that your issue occurs with:

tns --version 6.2.0
"tns-android": {
"version": "6.2.0"
},
"tns-ios": {
"version": "6.2.0"
}
"nativescript-ui-listview": "^8.0.1",
"tns-core-modules": "6.3.2",

Please tell us how to recreate the issue in as much detail as possible.

I have created a playground where you can see the android issue. But I don't have a physical IOS phone so I am unsure if you will be able to see the IOS issues on the playground.

  1. run playground
  2. swipe item
  3. look at console

Is there code involved? If so, please share the minimal amount of code needed to recreate the problem.

Here is a playground example that I was able to see the issue.
https://play.nativescript.org/?template=play-ng&id=OiVkmk

@quinnban
Copy link
Author

I removed and readded my ios platform and it seems to fix the problem. The android problem still remains.

@quinnban
Copy link
Author

I figured out the issue, in the "ui-listview.android.js" file the "ListViewSwipeActionsListenerImpl.prototype.onSwipeEnded"(line 716) function is not filled out but the "ListViewSwipeActionsListenerImpl.prototype.onExecuteFinished"(line 743 on mine) is. Copy and paste the code from the ladder function to the first and it will work as intended.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants