Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A noob friendly tutorial on "HDR to SDR conversion"? #16

Closed
BhaturaGuy opened this issue Dec 18, 2022 · 6 comments
Closed

A noob friendly tutorial on "HDR to SDR conversion"? #16

BhaturaGuy opened this issue Dec 18, 2022 · 6 comments

Comments

@BhaturaGuy
Copy link

Went through this hdr-toys.
And copied the shaders and config as it is.
and here's the result:
mpv --no-config with hdr file.
normal hdr

Hdr file with your config.
hdr to sdr conversion using your config

Sdr version of a file run with mpv --no-config

normal sdr version

I wanna know maybe I did something wrong? Or this is the actual output expected through your config.

@natural-harmonia-gropius

This comment was marked as outdated.

@natural-harmonia-gropius
Copy link
Owner

https://github.com/Natural-Harmonia-Gropius/mpv_config/tree/main/portable_config/shaders/hdr-toys#readme

Hello, I have written a very simple document and I would like to know what kind of information would be good for "noob", I will add it.

@BhaturaGuy
Copy link
Author

https://github.com/Natural-Harmonia-Gropius/mpv_config/tree/main/portable_config/shaders/hdr-toys#readme

Hello, I have written a very simple document and I would like to know what kind of information would be good for "noob", I will add it.

By that I meant written a format that anyone without an engineering degree would understand, and as it is right now it shouldn't require much I guess. Easy to understand now, though I guess mpv's learning curve is infinite.

@pintassilgo
Copy link

pintassilgo commented Jan 29, 2023

I'm also unable to get good results.

HDR example video: https://www.youtube.com/watch?v=hVvEISFw9w0

Firefox, HDR -> SDR done automatically by YouTube website:
image

I downloaded the video and opened it in standalone Firefox tab without YouTube website filters:
image

MPV default:
image

MPV using your portable_config without any change or addition:
image

I also tried replacing the
glsl-shader=~~/shaders/hdr-toys/tone-mapping/bt2446c.glsl
line by every other file in /shaders/hdr-toys/tone-mapping/, but none produced good results.

@natural-harmonia-gropius
Copy link
Owner

@pintassilgo I guess your mpv doesn't suppport vo=gpu-next.
get newer version from https://github.com/shinchiro/mpv-winbuild-cmake/releases

@pintassilgo
Copy link

pintassilgo commented Jan 29, 2023

My mpv is 0.35, built from git 20221222 (commit 657fd280).

gpu-next works here. I use Linux.

@natural-harmonia-gropius natural-harmonia-gropius transferred this issue from natural-harmonia-gropius/mpv-config Mar 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants