Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Window: Set always on top #129

Closed
woelper opened this issue Aug 27, 2022 · 6 comments
Closed

Window: Set always on top #129

woelper opened this issue Aug 27, 2022 · 6 comments
Labels
enhancement New feature or request

Comments

@woelper
Copy link
Contributor

woelper commented Aug 27, 2022

Winit has a method to set a window as "Always on top": https://docs.rs/winit/latest/winit/window/struct.Window.html#method.set_always_on_top

Would it make sense to expose this functionality inside notan as well? For multimedia apps this might be a useful feature.

@Nazariglez
Copy link
Owner

Hello!

It makes sense to me, it seems that also SDL2 and GLFW also support this so if somebody wants to create another backend with them the option is still there.

My main worry is how this should behave on web browsers, maybe just no-op? I don't see either a clear use for it on the web.

What do you think?

@Nazariglez Nazariglez added the enhancement New feature or request label Aug 30, 2022
@woelper
Copy link
Contributor Author

woelper commented Aug 30, 2022

Thanks so much for your answer! I fully agree with your thoughts on the web - I think this only useful in a desktop context and has no use on the web.

@Nazariglez
Copy link
Owner

Thanks so much for your answer! I fully agree with your thoughts on the web - I think this is only useful in a desktop context and has no use on the web.

Anytime!

I can do this. However is an easy change, how do you feel about sending a PR with it? It could be similar to this 1c96c5c, avoiding the web backend and also passing true/false on the WindowConfig like this: 0af6b7e

Let me know if feel like trying it!

@woelper
Copy link
Contributor Author

woelper commented Aug 31, 2022

Thanks! Yes, absolutely, I am happy to try that out! I'll let you know if I have something (or questions, if that's fine)!

Thanks!

@woelper
Copy link
Contributor Author

woelper commented Aug 31, 2022

Hi @Nazariglez ,
I started a PR here:
#132

I am unsure about the empty.rs - your feedback is greatly appreciated. Would you like me to add an example as well?

@Nazariglez
Copy link
Owner

It looks good to me, empty is just a mockup of the backend, some dummy thing to use in case no backend is present. I think that we don't need an example for this, but if you want we can add it of course.

Already merged, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants