Crashes on Nougat

[lenniea]

Running after updating the build and sdk-target to 24 crashes on Nexus 5X running Nougat:

11-21 20:48:33.674 12588-12588/? I/Provider.initialize: Starting provider: AliasProvider
11-21 20:48:33.679 12588-12588/? I/Provider.initialize: Starting provider: AppProvider
11-21 20:48:33.690 12588-12588/? I/Provider.initialize: Starting provider: ContactsProvider
11-21 20:48:33.695 12588-12588/? I/Provider.initialize: Starting provider: PhoneProvider
11-21 20:48:33.697 12588-12588/? I/Provider.initialize: Starting provider: SearchProvider
11-21 20:48:33.699 12588-12588/? I/Provider.initialize: Starting provider: SettingsProvider
11-21 20:48:33.701 12588-12588/? I/Provider.initialize: Starting provider: ShortcutsProvider
11-21 20:48:33.703 12588-12588/? I/Provider.initialize: Starting provider: TogglesProvider
11-21 20:48:33.745 12588-12607/? I/Adreno: QUALCOMM build                   : 74df444, I409c65498b
                                           Build Date                       : 06/22/16
                                           OpenGL ES Shader Compiler Version: XE031.08.00.02
                                           Local Branch                     : N16
                                           Remote Branch                    : 
                                           Remote Branch                    : 
                                           Reconstruct Branch               : 
11-21 20:48:33.753 12588-12607/? I/OpenGLRenderer: Initialized EGL, version 1.4
11-21 20:48:33.754 12588-12607/? D/OpenGLRenderer: Swap behavior 1
11-21 20:48:33.758 12588-12588/? I/Provider.loadOver: Done loading provider: AliasProvider
11-21 20:48:35.936 12588-12595/fr.neamar.kiss W/art: Suspending all threads took: 130.315ms
11-21 20:48:36.378 12588-12609/fr.neamar.kiss I/time: 2673 milliseconds to list apps
11-21 20:48:36.385 12588-12588/fr.neamar.kiss I/Provider.loadOver: Done loading provider: AppProvider
11-21 20:48:36.409 12588-12650/fr.neamar.kiss E/AndroidRuntime: FATAL EXCEPTION: AsyncTask #4
                                                                Process: fr.neamar.kiss, PID: 12588
                                                                java.lang.RuntimeException: An error occurred while executing doInBackground()
                                                                    at android.os.AsyncTask$3.done(AsyncTask.java:318)
                                                                    at java.util.concurrent.FutureTask.finishCompletion(FutureTask.java:354)
                                                                    at java.util.concurrent.FutureTask.setException(FutureTask.java:223)
                                                                    at java.util.concurrent.FutureTask.run(FutureTask.java:242)
                                                                    at android.os.AsyncTask$SerialExecutor$1.run(AsyncTask.java:243)
                                                                    at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1133)
                                                                    at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:607)
                                                                    at java.lang.Thread.run(Thread.java:761)
                                                                 Caused by: java.lang.SecurityException: Permission Denial: opening provider com.android.providers.contacts.ContactsProvider2 from ProcessRecord{59e05e3 12588:fr.neamar.kiss/u0a258} (pid=12588, uid=10258) requires android.permission.READ_CONTACTS or android.permission.WRITE_CONTACTS
                                                                    at android.os.Parcel.readException(Parcel.java:1683)
                                                                    at android.os.Parcel.readException(Parcel.java:1636)
                                                                    at android.app.ActivityManagerProxy.getContentProvider(ActivityManagerNative.java:4169)
                                                                    at android.app.ActivityThread.acquireProvider(ActivityThread.java:5434)
                                                                    at android.app.ContextImpl$ApplicationContentResolver.acquireUnstableProvider(ContextImpl.java:2267)
                                                                    at android.content.ContentResolver.acquireUnstableProvider(ContentResolver.java:1515)
                                                                    at android.content.ContentResolver.query(ContentResolver.java:514)
                                                                    at android.content.ContentResolver.query(ContentResolver.java:472)
                                                                    at fr.neamar.kiss.loader.LoadContactsPojos.doInBackground(LoadContactsPojos.java:61)
                                                                    at fr.neamar.kiss.loader.LoadContactsPojos.doInBackground(LoadContactsPojos.java:25)
                                                                    at android.os.AsyncTask$2.call(AsyncTask.java:304)
                                                                    at java.util.concurrent.FutureTask.run(FutureTask.java:237)
                                                                    at android.os.AsyncTask$SerialExecutor$1.run(AsyncTask.java:243) 
                                                                    at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1133) 
                                                                    at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:607) 
                                                                    at java.lang.Thread.run(Thread.java:761) 

[nmitsou]

Just to highlight the missing permission : Permission Denial: opening provider com.android.providers.contacts.ContactsProvider2 from Process record requires android.permission.READ_CONTACTS or android.permission.WRITE_CONTACTS

[ntninja]

Yes, that is because marshmellow introducted runtime-permissions and supporting those is not fun at all (#250). So currently KISS stays on Lollipop SDK until we can get full support for that working. Please also see the (short) discussion on commit 0252809, for some ideas on how we believe this should be implemented.

[Neamar]

I'll close this for now, since it won't be an issue while we remain on SDK 23.

At some point, we'll have to deal with this however :\