Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check and update readme, and document environment variable overrides and their usage #504

Open
shawaj opened this issue Mar 12, 2023 · 2 comments

Comments

@shawaj
Copy link
Member

shawaj commented Mar 12, 2023

For example all of the ones defined here:

hm-diag/hw_diag/app.py

Lines 34 to 42 in 23c6698

SENTRY_DSN = os.getenv('SENTRY_DIAG')
DIAGNOSTICS_VERSION = os.getenv('DIAGNOSTICS_VERSION')
BALENA_ID = os.getenv('BALENA_DEVICE_UUID')
BALENA_APP = os.getenv('BALENA_APP_NAME')
HEARTBEAT_INTERVAL_HOURS = float(os.getenv('HEARTBEAT_INTERVAL_HOURS', 24))
SHIP_DIAG_INTERVAL_HOURS = float(os.getenv('SHIP_DIAG_INTERVAL_HOURS', 1))
NETWORK_WATCHDOG_INTERVAL_HOURS = float(os.getenv('NETWORK_WATCHDOG_INTERVAL_HOURS', 1))
NEBRAOS_MIGRATION_INTERVAL_HOURS = float(os.getenv('NEBRAOS_MIGRATION_INTERVAL_HOURS', 24))
MIGRATION_TASK_DISABLED = os.getenv('NEBRA_CLOUD_MIGRATION_DISABLED', 'false').lower() == 'true'

And also here:

if os.getenv('SWARM_KEY_URI_OVERRIDE'):

There may be more elsewhere

@shawaj shawaj changed the title Document environment variable overrides and their use Document environment variable overrides and their usage Mar 12, 2023
@shawaj
Copy link
Member Author

shawaj commented Mar 14, 2023

Related to #442

@pritamghanghas
Copy link
Contributor

we should move all of them to a configuration module. There are too many and too spread out. Only downside is such a refactor will involve changing lot of test cases. But shouldn't be very hard to do. it will be easy to document and reference.

@shawaj shawaj changed the title Document environment variable overrides and their usage Check and update readme, and document environment variable overrides and their usage Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants