Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: check helium API and onboarding server for key #231

Closed
wants to merge 3 commits into from

Conversation

shawaj
Copy link
Member

@shawaj shawaj commented Mar 16, 2023

Issue

How

Screenshots

References

Relates-to: #230
Relates-to: NebraLtd/helium-syncrobit#2
Relates-to: #222
Closes: #221
Relates-to: #238
Ref: https://nebraltd.slack.com/archives/C024BNQ1Y6T/p1680959586571789?thread_ts=1680959586.571789&cid=C024BNQ1Y6T

Checklist

  • Tests added
  • Cleaned up commit history (rebase!)
  • Documentation added
  • Thought about variable and method names

Check for the existence of a duplicate key on the helium API and onboarding server
@sonarcloud
Copy link

sonarcloud bot commented Mar 16, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@shawaj
Copy link
Member Author

shawaj commented May 20, 2023

Probably no longer needed, can reopen if necessary later

@shawaj shawaj closed this May 20, 2023
@shawaj shawaj deleted the shawaj/keyapi branch May 20, 2023 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Need to support hardware variants with multiple possible ECC locations
1 participant