Implement login/logout, registry, bandwidth used. #33
Conversation
Track registry accesses.
… correct download size.
…based on subscription date.
Bandwidth moved to a new type UserDetails, so we don't make these expensive calculations any time we need a user.
…lide with other local Mongos.
Refresh the user from DB when fetching their details.
| @@ -23,7 +24,7 @@ type UploadResponseDTO struct { | |||
| ID string `bson:"_id" json:"id"` | |||
| Skylink string `bson:"skylink" json:"skylink"` | |||
| Name string `bson:"name" json:"name"` | |||
| Size uint64 `bson:"size" json:"size"` | |||
| Size int64 `bson:"size" json:"size"` | |||
There was a problem hiding this comment.
It's confusing to keep converting between int64 and uint64, so I started using int64 for all size and bandwidth values.
|
|
||
| // userBandwidth reports the total bandwidth used by the user. | ||
| func (db *DB) userBandwidth(ctx context.Context, id primitive.ObjectID) (int64, error) { | ||
| var bandwidthAtomic int64 |
There was a problem hiding this comment.
Consistency. All file sizes and bandwidth are now int64. Is there a benefit of having this be uint64?
database/user_test.go
Outdated
| {size: 1 * MiB, result: 40 * MiB}, | ||
| {size: 4 * MiB, result: 40 * MiB}, | ||
| {size: 5 * MiB, result: (40 + 120) * MiB}, | ||
| {size: 50 * MiB, result: (40 + 2*120) * MiB}, |
There was a problem hiding this comment.
I'm not sure I'm following here, could you elaborate on why a 50MiB upload results in 290MiB bandwidth usage/cost?
There was a problem hiding this comment.
The base sector is 4MB and has 1/10 redundancy, so it uses 40MB.
The remaining 46MB fit into 2 chunks of 40MB each. Those have 1/3 redundancy, so they use 120MB per chunk.
40 + 2*120 = 280
database/user.go
Outdated
| return time.Time{}, errors.AddContext(err, "failed to fetch user") | ||
| } | ||
| now := time.Now().UTC() | ||
| daysDelta := now.Day() - user.SubscribedUntil.Day() |
There was a problem hiding this comment.
Could you explain in a comment what the goal is here, it's confusing, at least to me.
So you take the subscribed until, and subtract that from the current day, so if we're
feb 3rd, and he was subscribed until jan 28th, that's -25. Then you add 25 days to today,
I guess that's feb 28 or mar 1, and daysDelta was smaller than zero, so then you subtract a month and use daysDelta is the day? Surely there is a bug in this piece of code right, I don't see it but I'm pretty sure there is one :D
There was a problem hiding this comment.
Time is hard. :D
Yes, there was a bug. I hope I managed to fix it. I also added a lengthy comment.
Here is how it looks now:
func MonthStart(subscribedUntil time.Time) time.Time {
now := time.Now().UTC()
// Check how many days are left until the end of the user's subscription
// month. Then calculate when the last subscription month started. We don't
// care if the user is no longer subscribed and their sub expired 3 months
// ago, all we care about here is the day of the month on which that
// happened because that is the day from which we count their statistics for
// the month. If they were never subscribed we use Jan 1st 1970 for
// SubscribedUntil.
daysDelta := subscribedUntil.Day() - now.Day()
d := now.AddDate(0, -1, daysDelta)
return time.Date(d.Year(), d.Month(), d.Day(), 0, 0, 0, 0, time.UTC)
}
|
Overall it looks good, keeping in mind this is a beta release though. I went over it but decided not to nit nor go into much detail. I guess any bugs will surface and are non-vital at the moment. We've cut quite a few corners so I guess the important thing is to get it out. |
Features:
skynet-jwtcookiesupport streaming downloads- we decided to treat them as separate downloads for the moment