Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove tls mode #1322

Closed
Neilpang opened this issue Mar 2, 2018 · 6 comments
Closed

Remove tls mode #1322

Neilpang opened this issue Mar 2, 2018 · 6 comments

Comments

@Neilpang
Copy link
Member

Neilpang commented Mar 2, 2018

tls mode is removed from ACME protocol:
letsencrypt/boulder#3297 (comment)

we will remove it too.

@FernandoMiguel
Copy link

expected.
thanks for the heads up

@cpu
Copy link

cpu commented Mar 2, 2018

Note that while TLS-SNI-01 is removed from the specification Boulder and Let's Encrypt's V1 API still support TLS-SNI-01 for the two cases we described here. We'll eventually remove support from Boulder entirely but it hasn't happened yet and we haven't picked a fixed date to do so. You might want to wait for Boulder to remove the code before you delete it yourself (or not! up to you ;-))

@Neilpang
Copy link
Member Author

Neilpang commented Mar 2, 2018

@cpu thank you.
We will wait for a period.

@Neilpang
Copy link
Member Author

Let's remove the tls doc first.

@Neilpang Neilpang reopened this Mar 14, 2018
Neilpang pushed a commit that referenced this issue Mar 14, 2018
@xj25vm
Copy link

xj25vm commented Mar 21, 2018

It would be really nice if the --tls would have been left in acme.sh, and would just return an error similar to:

"This option has been deprecated at Let's Encrypt and removed from acme.sh"

When I tried to use it recently it just returns "Unknown parameter --tls" - which is really confusing, as it used to be an option until recently, and I banged by my head against it for a while, thinking that I copied my scripts and command wrong somehow. It isn't even mentioned on the https://github.com/Neilpang/acme.sh/wiki/How-to-issue-a-cert page - so it took me a while to find this thread. It would be user friendly if it would be mentioned in the docs that the --tls has been removed. At the moment all mentions of it seem to have completely vanished.

DavidPagels added a commit to DavidPagels/hm-letsencrypt that referenced this issue May 25, 2020
The tls flag was removed from acme.sh acmesh-official/acme.sh#1322
@Neilpang
Copy link
Member Author

we have --alpn mode.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants