Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

can not get domain token $d #191

Closed
Rikairchy opened this issue May 21, 2016 · 12 comments
Closed

can not get domain token $d #191

Rikairchy opened this issue May 21, 2016 · 12 comments

Comments

@Rikairchy
Copy link

Rikairchy commented May 21, 2016

Trying acme.sh on a new box. I get an error stating that the domain token cannot be found.

I'm using Cloudlfare's DNS (API key and email configured) on Fedora 23 using a non-root account.

I have uninstalled the acme.sh script and removed the ~/.acme.sh directory. Here is the output when running the command:

[znc@fedora` ~]$ acme.sh --dns dns_cf --issue -d znc.rikairchy.net
[Fri May 20 23:07:03 EDT 2016] Skip register account key
[Fri May 20 23:07:03 EDT 2016] Creating csr
[Fri May 20 23:07:03 EDT 2016] Single domain='znc.rikairchy.net'
[Fri May 20 23:07:03 EDT 2016] Verify each domain
[Fri May 20 23:07:03 EDT 2016] Getting webroot for domain='znc.rikairchy.net'
[Fri May 20 23:07:03 EDT 2016] Getting token for domain='znc.rikairchy.net'
[Fri May 20 23:07:04 EDT 2016] Error, can not get domain token znc.rikairchy.net
[znc@fedora ~]$ which acme.sh
alias acme.sh='/home/znc/.acme.sh/acme.sh'
~/.acme.sh/acme.sh

@epheph
Copy link

epheph commented May 21, 2016

I just ran into this issue. It seems like the json responses have changed and are now being pretty-printed, completely destroying the grep'ing logic used to extract the variables. I fixed a few, but there's some large issues now, like some same-line pattern matching for values that are now on separate lines.

It would be awesome to use something like jq for this, but that would destroy the bash purity...

@Rikairchy
Copy link
Author

Main reason I love this script is the Cloudflare integration. I have about 60 or so total subdomains that I use through a few certs. It's a bit of a pain to update each TXT record each time.

@zoc
Copy link

zoc commented May 21, 2016

Yeah, same issue for me. I also chose this script for the Cloudflare integration. For now I only have one certificate in production but I was expecting to be able to request a few ones this morning.

I think that jq might be the solution, even if it is adding a dependency on another external tool. Anyway there are already dependencies, like netcat and curl (but I have to admit that they are more "standard" tools).

@Neilpang
Copy link
Member

Yes, the response from let's encrypt is formated. I'm fixing it now.

@Rikairchy
Copy link
Author

@Neilpang You're awesome. Anything we can do to help?

@Neilpang
Copy link
Member

No, thanks. just wait a few minutes.

@Neilpang
Copy link
Member

fixed at 2ee5d87

Please try again.

@zoc
Copy link

zoc commented May 21, 2016

Seems to be OK for me, thank you so much !

@ElectronicWar
Copy link

v2.2.5 works for me again, thanks a lot!

@epheph
Copy link

epheph commented May 22, 2016

Confirmed 2ee5d87 fixed the issue (for now!)

@petervanderwal
Copy link

petervanderwal commented May 23, 2016

Related to this issue:
lines 1489 & 1490 should be
response="$(echo $response | _dbase64 "multiline" | tr -d "\r\n" )"
_err "Sign failed: $(echo "$response" | grep -o '"detail" *: *"[^"]*"')"

@Neilpang
Copy link
Member

@petervanderwal fixed : eae2909

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants