Cleanup old DNS TXT records

[klamann]

I recently stumbled upon an issue where due to a number of failed ACME challenges, several DNS TXT records have been set by acme.sh through the API of my DNS provider, but they were never deleted.

The DNS records were set by the dns_dynu.sh plugin, but because dynu.com has a pretty low limit for the number of DNS records that can be set, further requests to their API failed with a "Quota Exception" message.

Can we change the challenge-response process in a way that the TXT records set through one of the dnsapi plugins are always removed, even if the request fails and no certificate is issued? Or maybe check that all TXT records that have been set in a previous session have actually been deleted, when a new certificate is requested? That way we can make sure that old records don't pile up, even if the process is is terminated right after the TXT records have been set.

[Neilpang]

please try again.

[JMC-PK]

@Neilpang Id like to say that this is still occurring on 2.8.2.

I frequently have old empty text records when using the dns api with GoDaddy.

Since they are empty, it is partially cleaning up and I know which are safe to delete manually, but it should remove the whole record itself.

These were created last week with v2.8.2 when I removed the old empties and reissued some certs.