Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wget support is broken #724

Closed
nextgens opened this issue Mar 15, 2017 · 4 comments
Closed

Wget support is broken #724

nextgens opened this issue Mar 15, 2017 · 4 comments

Comments

@nextgens
Copy link

_get() is hopelessly broken if curl isn't available: from the man page:

"Specification of an empty string as the header value will clear all previous user-defined headers."

https://github.com/Neilpang/acme.sh/blob/master/acme.sh#L1622

@Neilpang
Copy link
Member

Did you see any problem ?

for wget, the header is in reversed order:

wget .....    --header "$_H5" --header "$_H4" --header "$_H3" --header "$_H2" --header "$_H1" 

@nextgens
Copy link
Author

nextgens commented Mar 15, 2017

Yes, dns_aws is currently broken; The get request to list the zones fails:
https://github.com/Neilpang/acme.sh/blob/master/dnsapi/dns_aws.sh#L86

H3 is set, H2 is empty, H1 is set ... the request is fired with just H1 and the auth fails

Neilpang pushed a commit that referenced this issue Mar 15, 2017
@Neilpang
Copy link
Member

fixed, please try with the dev branch:

export BRANCH=dev
acme.sh --upgrade

@nextgens
Copy link
Author

It's fixed it; thanks! You rock!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants