Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added fixes so BuyPass Go ACME server can be used #1989

Merged
merged 3 commits into from
Dec 28, 2018
Merged

Added fixes so BuyPass Go ACME server can be used #1989

merged 3 commits into from
Dec 28, 2018

Conversation

mysteq
Copy link

@mysteq mysteq commented Dec 27, 2018

Had to add a few tweaks to be able to use the ACME server for BuyPass GO, as it seems to not quite conform to the ACME v1 specs implemented currently in acme.sh.

Resources:
https://api.buypass.com/acme/directory
https://www.buypass.com/ssl/resources/go-ssl-technical-specification

The tweaks should not affect existing functionality, and I've done some basic testing on CentOS.

@Neilpang
Copy link
Member

If certbot can work out of the box aginst buypass, we should also be able to.
I don't think we need so much buypass specific tricks.

please fix it in the code directly, I think it's in the ACME v1 specific blocks.

Thaanks

@Neilpang
Copy link
Member

I think we should be able to remove any "buypass" or "BUYPASS" string from the code.
please go ahead.

@mysteq
Copy link
Author

mysteq commented Dec 28, 2018

Changed the code to fix it directly in v1 code then.

Tested this with CloudFlare DNS authorization on a CentOS 7 server, with:
Let's Encrypt Staging v1
Let's Encrypt Staging v2
BuyPass

acme.sh Outdated
@@ -13,6 +13,8 @@ _SCRIPT_="$0"

_SUB_FOLDERS="dnsapi deploy"

BUYPASS_CA="https://api.buypass.no/acme/directory"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove it

@Neilpang Neilpang merged commit b38c4e1 into acmesh-official:dev Dec 28, 2018
@mysteq mysteq deleted the buypass-support branch December 28, 2018 16:45
@m-ueberall
Copy link

Apologies if this has been mentioned elsewhere, but I did not find it: Where are certificates being kept if you use the exact same parameters/(sub)domains but reference different server URIs/CAs?
I'm not sure the resulting files can coexist in ~/.acme.sh/sub.domain.tld[_ecc]--will users get to see a warning when existing files from a different CA would be overwritten or should this at least be mentioned somewhere else?

@Neilpang
Copy link
Member

Neilpang commented Jan 4, 2019

@m-ueberall

will users get to see a warning

Yes, if there is an existing cert, no matter from the same CA or a different CA, the user always gets a warning.

The user MUST use --force parameter to overwritten the existing cert.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants