Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mail notify #2259

Merged
merged 16 commits into from May 19, 2019
Merged

Add mail notify #2259

merged 16 commits into from May 19, 2019

Conversation

honzahommer
Copy link
Contributor

Notify hook that uses sendmail.

@Neilpang
Copy link
Member

I don't like a dedicated hook for sendmail only.
please implement it in the mail.sh hook: https://github.com/Neilpang/acme.sh/blob/master/notify/mail.sh

In this hook, please try to use both mail command and sendmail command.

if mail exists, we use mail, if sendmail exists we use sendmail.

what do you think ?

@Neilpang
Copy link
Member

it can also try with mutt if mail or sendmail neither exists.
see:
https://tecadmin.net/ways-to-send-email-from-linux-command-line/

@honzahommer honzahommer changed the title Add sendmail notify Add mail notify May 12, 2019
@Neilpang
Copy link
Member

please make sure you tested EVERY commands, such as: mail, sendmail or mutt

@honzahommer
Copy link
Contributor Author

I don't like a dedicated hook for sendmail only.
please implement it in the mail.sh hook: https://github.com/Neilpang/acme.sh/blob/master/notify/mail.sh

In this hook, please try to use both mail command and sendmail command.

if mail exists, we use mail, if sendmail exists we use sendmail.

what do you think ?

Yeah, great idea. I move sendmail to mail and add mail notify support. But I need to check if mail command works correctly - it's not done yet.

@honzahommer
Copy link
Contributor Author

please make sure you tested EVERY commands, such as: mail, sendmail or mutt

I tested all methods, works fine.

@Neilpang
Copy link
Member

please create a new issue for reporting bugs, like this:
https://github.com/Neilpang/acme.sh/wiki/DNS-API-Dev-Guide#10-please-create-a-new-issue-for-future-bugs

@honzahommer
Copy link
Contributor Author

please create a new issue for reporting bugs, like this:
https://github.com/Neilpang/acme.sh/wiki/DNS-API-Dev-Guide#10-please-create-a-new-issue-for-future-bugs

#2263

@Neilpang
Copy link
Member

please update your usage here:
https://github.com/Neilpang/acme.sh/wiki/notify

notify/mail.sh Outdated Show resolved Hide resolved
@honzahommer
Copy link
Contributor Author

@Neilpang Neilpang merged commit ae380cb into acmesh-official:dev May 19, 2019
@honzahommer honzahommer deleted the notify-sendmail branch May 29, 2019 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants