Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test dockerized app files #354

Open
Nekroze opened this issue Mar 3, 2019 · 3 comments
Open

Test dockerized app files #354

Nekroze opened this issue Mar 3, 2019 · 3 comments
Labels
Test Add, remove, or alter tests
Projects

Comments

@Nekroze
Copy link
Owner

Nekroze commented Mar 3, 2019

Change Request

Please describe the current behaviour

At present dab only tests apps by starting a select few.

What is suboptimal about the current behaviour

The current behaviour is insufficient because apps may be broken in easy to detect ways in a merge without knowing.

Describe the way you think it should behave

Run docker-compose build -f docker-compose.*.yml in its own parallel test job that would fail if any Dockerfile or docker-compose.yml is invalid/malformed.

@Nekroze Nekroze added Tweak Change to existing components Test Add, remove, or alter tests and removed Tweak Change to existing components labels Mar 3, 2019
@Nekroze
Copy link
Owner Author

Nekroze commented Mar 6, 2019

Testing by creating all services takes far too long in CI. Perhaps look at some linting to check validity.

@Nekroze Nekroze added this to One day... in Roadmap Mar 18, 2019
@tommymcguiver
Copy link
Collaborator

Can validate config like so
[kenm@gijoevm020 docker]$ docker-compose -f docker-compose.vault.yml config -q
echoERROR: Service 'vault' depends on service 'consul' which is undefined.

@Nekroze
Copy link
Owner Author

Nekroze commented Jul 16, 2019

@tommymcguiver good idea! we could use dab apps config which does the dependency lookup and will error if the yaml is an invalid docker-compose schema... Doesn't ensure the apps function as intended but this would be an improvement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Test Add, remove, or alter tests
Projects
Roadmap
One day...
Development

No branches or pull requests

2 participants