Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Milestone 8 : all movies counter #29

Merged
merged 5 commits into from Mar 10, 2022
Merged

Conversation

Nemwel-Boniface
Copy link
Owner

@Nemwel-Boniface Nemwel-Boniface commented Mar 9, 2022

Hello @zmekonnen251 馃憢 馃憢

In this milestone I was able to:

  • Update the README.md to include a live demo of the project
  • Included the all movies counter
  • Followed list of best practices for JavaScript.
  • Met all the project requirements
  • No linter errors

Thank you for reviewing my work.

@netlify
Copy link

netlify bot commented Mar 9, 2022

鉁旓笍 Deploy Preview for happy-payne-5d37ab ready!

馃敤 Explore the source changes: ed12732

馃攳 Inspect the deploy log: https://app.netlify.com/sites/happy-payne-5d37ab/deploys/6229731d38cc6d000adf3638

馃槑 Browse the preview: https://deploy-preview-29--happy-payne-5d37ab.netlify.app

@zmekonnen251 zmekonnen251 self-requested a review March 9, 2022 22:43
Copy link
Collaborator

@zmekonnen251 zmekonnen251 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Nemwel-Boniface

Your project is complete! There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 馃帀

Cheers and Happy coding!馃憦馃憦馃憦

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.


As described in the Code reviews limits policy you have only 3 code reviews per project. If you think that the code review was not fair, you can request a second opinion using this form.

@Nemwel-Boniface Nemwel-Boniface merged commit d1c605f into development Mar 10, 2022
@Nemwel-Boniface Nemwel-Boniface deleted the countAllMovies branch March 10, 2022 03:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants