Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ES6 syntax where ever possible. #2

Closed
muneebulrehman opened this issue Feb 17, 2022 · 2 comments
Closed

Use ES6 syntax where ever possible. #2

muneebulrehman opened this issue Feb 17, 2022 · 2 comments

Comments

@muneebulrehman
Copy link

Hey, Great job with the project. I have a suggestion for you.

  • I can see that you have used a for loop for traversing an array which holds the hard coded values. You can rather use forEach() method to do the same.

Good luck with the rest of the project. Happy coding. ⭐😊✌️

@souad988
Copy link

Hi nemwell you did a great job implementing the requirements .
I have only one thing to mention, since you are displaying a list it's better to use a li tags
otherwise everything is good

@Nemwel-Boniface
Copy link
Owner

Hello @muneebulrehman and @souad988 👋

  • Thank you for your suggestions. I made all the suggested changes and it should now be perfect as per your recommendations.

Cheers,
#Happycoding

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants