Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't crash when fees in undefined #50

Open
Empty2k12 opened this issue Sep 4, 2020 · 1 comment
Open

Don't crash when fees in undefined #50

Empty2k12 opened this issue Sep 4, 2020 · 1 comment

Comments

@Empty2k12
Copy link
Contributor

Max managed to get a transaction which was manually closed by Velo in the database and which has no fees field in the /bookings endpoint.

Not sure what the best fix is? Assume everything nullable and provide a default for every field?

@NeoLegends
Copy link
Owner

I guess we can special-case this occurency by maling the fee field 0, or we extend the logic to tread falsy values there as 0, basically turning kff „strict“ comparisons for that value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants