Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove rails dependency #39

Open
Neodelf opened this issue Apr 29, 2020 · 2 comments
Open

Remove rails dependency #39

Neodelf opened this issue Apr 29, 2020 · 2 comments
Labels
dependencies Pull requests that update a dependency file

Comments

@Neodelf
Copy link
Owner

Neodelf commented Apr 29, 2020

Guys, now the gem has rails dependency. It helps with developing some general features. But if we remove it, we will be able to work with all Rack-oriented applications. So here we can discuss that removing process.
Please feel free to ask any questions!

@Neodelf Neodelf added the dependencies Pull requests that update a dependency file label Apr 29, 2020
@pineapplethief
Copy link
Contributor

I guess we could use sinatra instead and mount it a-la sidekiq. I would suggest using sinatra as a peer dependency to give client apps more flexibility and avoid version resolution conflicts. We also would need to figure lowest common denominator, i.e. minimum requirements on sinatra version in order to work.
I think reading sidekiq source code would be useful for that.

@Neodelf
Copy link
Owner Author

Neodelf commented May 19, 2020

Nice suggestion. But I read code of sidekiq and figured out that it doesn't have sinatra dependency. They wrote code that uses only rack.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

No branches or pull requests

2 participants