-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
프로필 수정 페이지 #257
프로필 수정 페이지 #257
Conversation
울 웹쁜이 고생많았어 ! 여기서 미리보기로 보면서 쉬어~ 다른 웹쁜이들한테도 자랑해줘~ |
울 웹쁜이 고생많았어 ! 여기서 미리보기로 보면서 쉬어~ 다른 웹쁜이들한테도 자랑해줘~ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
고생하셨습니다💜💜🤍🤍💓💓
</StMyKeywordHeader> | ||
</StMyKeywordDelete> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
요 사이에 키워드 리스트 와야 할 것 같은데 혹시 아직 안한 건지 제가 잘못 이해한건지 궁금합니다!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
제대로 이해한 거 맞고 아직 미완입니다 !!
바텀시트에서 다른 링크로 넘어가는 부분까지 넣고 싶어서 페이지 윗부분만 살짝 만들었어요
남은 부분은 다음 PR에 올릴게유 😉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
넴💟💟
</StMyKeywordHeader> | ||
<MyPageEditBottomSheet |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
여기 사이두요! (키워드 리스트 머시깽)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
다음부터 헷갈리지 않게 PR에 꼼꼼하게 적어둘게용 !! 확인 감삼다 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(위에 답변이랑 같은 내용)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
허걱 죄송하지만 PR 꼼꼼히 제가 안읽은 듯😂 넴넴!!
import { StMyKeywordEdit, StMyKeywordHeader } from './style'; | ||
import { IcMeatball } from '@assets/icons'; | ||
|
||
function MyKeywordEdit() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이 페이지는 수정하기 보다는 조회하는 용도의 페이지인 것 같아서 Edit가 안붙는게 더 낫지 않나 싶습니다!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
오 좋아용 Edit 빼는 걸로 수정하겠습니다 ✍️
const openBottomSheet = () => { | ||
setIsBottomSheetOpened(true); | ||
}; | ||
|
||
const closeBottomSheet = () => { | ||
setIsBottomSheetOpened(false); | ||
}; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
한번씩 밖에 안쓰이는 것 같은데 함수 선언하지 않고 익명 함수로 바로 쓰는 건 어떨까 싶어용 setState 이름도 직관적으로 잘 지어놨으니까!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
넵 좋아용 수정했습니다 🥳
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
수고하셨씁니다!!@!@!@
const idStartCheck = /^[a-z]/; | ||
|
||
setIsEditConditionPassed({ | ||
id: idCheck.test(inputId) && idStartCheck.test(inputId), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이 집 정규표현식 잘하네 ...
32줄 36줄 40줄에서 체크를 돌려서 총 4번 돌아가는데, 변수 하나에 담구면 처음 2번만 실행될 듯해요!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ㅎㅎ 넵넵 반영하겠습니당~~!
if (!idStartCheck.test(inputId)) { | ||
setErrorMsg('*아이디의 첫 글자는 영문 소문자'); | ||
} | ||
}, [inputId, inputName]); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
inputId가 바뀔 때, inputName이 바뀔 때 둘 다 이 useEffect가 돌아갈 텐데, 쪼개도 괜찮을 듯해요!!
id가 바뀌고 있을 때 name의 유효성을 검사해줄 필요는 없으니께유..!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
오 맞아요 쪼개는 걸로 수정해보겠습니다 ㅎㅎ
const MyProfileEdit = lazy(() => import('@pages/Edit/Profile')); | ||
const MyKeywordDelete = lazy(() => import('@pages/Edit/DeleteKeyword')); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
레이지 로딩까지.. 멋져 👍 👍 👍
울 웹쁜이 고생많았어 ! 여기서 미리보기로 보면서 쉬어~ 다른 웹쁜이들한테도 자랑해줘~ |
⛓ Related Issues
📋 작업 내용
📌 PR Point
👀 스크린샷 / GIF / 링크