Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stuff missing in target_speaker #4

Closed
The-Gig opened this issue Sep 9, 2019 · 3 comments
Closed

Stuff missing in target_speaker #4

The-Gig opened this issue Sep 9, 2019 · 3 comments

Comments

@The-Gig
Copy link
Collaborator

The-Gig commented Sep 9, 2019

Hi! I just noticed that here
https://github.com/NeonKnightOA/oagamepack/blob/master/oa.game/baseoa/entities.ent
the spawnflags "looped_on" is missing in target_speaker definition. I don't know if other files need to be fixed for that, too.

Further looking into at target_speaker, I see that it currently also doesn't mention these keys:

  • noise
  • wait
  • random
  • targetname

Also, maybe "notes" mentioning that it's possible to use like "*falling1" to play character-specific sounds, that sounds have to be mono, that 32 bit pcm is not supported and that ogg work only if the extension is omitted would be useful.

@NeonKnightOA
Copy link
Owner

Just on that file or all of this also applies to entities.def?
It's useful to know this.

@The-Gig
Copy link
Collaborator Author

The-Gig commented Sep 24, 2019

Also in https://github.com/NeonKnightOA/oagamepack/blob/master/oa.game/baseoa/entities.def
target_speaker is quite scarce in infos, it doesn't mention noise, wait, random, targetname, and has got no notes. But it seems to mention "looped_on" flag existence (although not explaining its behavior).

@NeonKnightOA
Copy link
Owner

Solved in ba78475. The problem also affected other entities.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants