Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creating reference typed variants of several value type-only components causes crashes #1855

Closed
Zyzyl opened this issue Mar 22, 2021 · 3 comments
Labels
Bug Something isn't working

Comments

@Zyzyl
Copy link
Collaborator

Zyzyl commented Mar 22, 2021

Describe the bug

Attempting to create or interact with reference typed variants of several different components which should only accept a value type causes crashes.

Relevant issues

#724, #1230 - both fixed. Possibly others too.

To Reproduce

Attempting to create any of the following via the Add Component dialog with the Slot type will immediately freeze and then crash Neos.

  • ValueProxy<T>
  • SetValue<T>
  • ValueRadio<T>
  • ButtonValueCycle<T>
  • ButtonValueSet<T>
  • ValueOptionDescriptionDriver<T>
  • ButtonRelay<T>

Attempting to create a ValueMultiplexer<Slot> happens successfully, however Neos freezes and crashes if you press the 'Add' button.

Attempting to create a (UIX) Slider<Slot> crashes the session.

It is also possible to create a ValueDriver<Slot>, this seems benign but I don't think it's functional (I couldn't drag and drop references into the fields).

Expected behavior

It shouldn't be possible to instantiate reference typed variants of these components, similar to how one cannot for e.g. ValueField<T>.

Bug information (please complete the following information):

  • Neos Version: 2021.3.16.1287
  • Neos Platform: Windows

Reporters:

Zyzyl#1441
Banane9#5929 noted the ValueProxy issue in Discord which prompted me to look for others

@Zyzyl Zyzyl added the Bug Something isn't working label Mar 22, 2021
@Frooxius
Copy link
Collaborator

We already have report for this here: #1852 It's a general issue, I have a fix coming in the next build.

@Frooxius Frooxius added the Duplicate This issue or pull request already exists label Mar 22, 2021
@Frooxius Frooxius reopened this Mar 22, 2021
@Frooxius
Copy link
Collaborator

Ah nevermind, this is actually different for some of them, sorry, some of them were missing checks in the first place! Fix coming too for those.

@Frooxius Frooxius removed the Duplicate This issue or pull request already exists label Mar 22, 2021
@Frooxius
Copy link
Collaborator

Added validation to all these in 2021.3.23.231, thanks for the findings!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants