Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JOSS Review (optional): Make functions internal #40

Closed
mhesselbarth opened this issue Aug 28, 2023 · 1 comment
Closed

JOSS Review (optional): Make functions internal #40

mhesselbarth opened this issue Aug 28, 2023 · 1 comment

Comments

@mhesselbarth
Copy link

I think there are a few functions that could be made internal testNull() (besides others). In my personal experience, limiting the exported functions to the core functionality is often beneficial to no confuse less experienced users.

openjournals/joss-reviews#5561
@sedv8808
Copy link
Collaborator

Commit 6771e8a addresses this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mhesselbarth @sedv8808