Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cosmoz-data-nav possibility to inject into data-nav template #50

Open
plequang opened this issue Apr 19, 2018 · 4 comments
Open

cosmoz-data-nav possibility to inject into data-nav template #50

plequang opened this issue Apr 19, 2018 · 4 comments
Assignees

Comments

@plequang
Copy link
Contributor

(Copied from previous issue tracker, not sure this is still valid. Ask @nomego before starting anything on it)

Currently, the prev/next button used to navigate through items in <cosmoz-data-nav> are specified in the template, for example:

<cosmoz-data-nav ...
  <template>
    <div>
      Some content to display item
      <paper-icon-button disabled$="[[ prevDisabled ]]" icon="chevron-left" cosmoz-data-nav-select="-1"></paper-icon-button>
      <paper-icon-button disabled$="[[ nextDisabled ]]" icon="chevron-right" cosmoz-data-nav-select="+1"></paper-icon-button>
      </div>
  </template>
</cosmoz-data-nav>

Would be nice if the buttons/chevrons could be handled by cosmoz-data-nav instead (and atStart/atEnd) to generalize further.. but can't really access it.
Any elegant way to do this ?

@nomego
Copy link
Contributor

nomego commented Jun 18, 2018

Is this fixed @megheaiulian ?

@megheaiulian
Copy link
Collaborator

@nomego Not yet but I am working on this.

@megheaiulian
Copy link
Collaborator

@nomego @plequang This is easier to fix if we go 2.x only. Otherwise it's another async template to take care of and increases complexity in the component. With 2.x class based we can provide an insertion point and push that content to the data-nav item content. More info: https://www.polymer-project.org/2.0/docs/devguide/dom-template#insertcontent

@nomego
Copy link
Contributor

nomego commented Aug 27, 2018

Ok, not a high priority case but 2.x is the way to go (or 3.x)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants