Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

harmonize timestamp types #117

Closed
2 tasks done
aszepieniec opened this issue Mar 8, 2024 · 5 comments
Closed
2 tasks done

harmonize timestamp types #117

aszepieniec opened this issue Mar 8, 2024 · 5 comments
Labels
good first issue Good for newcomers

Comments

@aszepieniec
Copy link
Contributor

aszepieniec commented Mar 8, 2024

Various types are used throughout the code base to capture dates (with time). By convention we count the number of milliseconds since the Unix epoch, but even for this number the types Duration, u64, and BFieldElement are used rather interchangeably. Note that BFieldElement is used for consensus-critical data structures such as Block and Transaction.

  • harmonize timestamp types
  • define and use boilerplate-reducing convenience functions
@aszepieniec aszepieniec added the good first issue Good for newcomers label Mar 8, 2024
@elielnfinic
Copy link
Contributor

elielnfinic commented Mar 26, 2024

Is there anybody working on this? If not, I can work on it.

@dan-da
Copy link
Collaborator

dan-da commented Mar 26, 2024

@elielnfinic no one is working on it that I know of. A PR would be welcome.

edit: it looks like this is addressed by 9e55a5b actually.

@aszepieniec may be waiting on #120 before merging to master.

@elielnfinic
Copy link
Contributor

Good that a custom Timestamp model was created.

@dan-da
Copy link
Collaborator

dan-da commented Apr 6, 2024

@aszepieniec With #124 merged, maybe now is a good time to get 9e55a5b into master? I'm guessing there might be some conflicts to resolve.

@aszepieniec
Copy link
Contributor Author

@aszepieniec With #124 merged, maybe now is a good time to get 9e55a5b into master? I'm guessing there might be some conflicts to resolve.

Yes it is. No time like the present.

@dan-da dan-da closed this as completed in 9e55a5b Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants